Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(zmq): add timeout for receive #3210

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

ngjaying
Copy link
Collaborator

avoid random panic when rule stops and receive is still running

@ngjaying ngjaying force-pushed the v2bugfix branch 3 times, most recently from 89d51a9 to 175ced3 Compare September 19, 2024 07:22
@ngjaying ngjaying marked this pull request as ready for review September 19, 2024 08:00
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.09%. Comparing base (8760def) to head (789c48a).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/zmq/source.go 64.52% 9 Missing and 2 partials ⚠️
extensions/impl/zmq/sink.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3210      +/-   ##
==========================================
+ Coverage   71.01%   71.09%   +0.08%     
==========================================
  Files         392      395       +3     
  Lines       43959    44019      +60     
==========================================
+ Hits        31215    31294      +79     
+ Misses      10261    10227      -34     
- Partials     2483     2498      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying force-pushed the v2bugfix branch 8 times, most recently from 25584aa to d6434ef Compare September 19, 2024 11:41
avoid random panic when rule stops and receive is still running

Signed-off-by: Jiyong Huang <[email protected]>
Also add jmeter testing

Signed-off-by: Jiyong Huang <[email protected]>
@ngjaying ngjaying merged commit bd0fa0a into lf-edge:master Sep 20, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants