Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split sink batch #2745

Merged
merged 3 commits into from
Mar 29, 2024
Merged

refactor: split sink batch #2745

merged 3 commits into from
Mar 29, 2024

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Accumulate batch inputs and send out at once

Signed-off-by: Jiyong Huang <[email protected]>
@ngjaying ngjaying force-pushed the split branch 4 times, most recently from 8166f56 to 95a3f0a Compare March 28, 2024 08:56
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 63.15%. Comparing base (bf3b679) to head (390979c).

Files Patch % Lines
internal/topo/node/batch_op.go 77.23% 22 Missing and 1 partial ⚠️
internal/topo/node/sink_node.go 75.00% 5 Missing and 1 partial ⚠️
internal/topo/planner/sink_planner.go 84.62% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
- Coverage   63.15%   63.15%   -0.01%     
==========================================
  Files         345      346       +1     
  Lines       39283    39312      +29     
==========================================
+ Hits        24809    24824      +15     
- Misses      12301    12315      +14     
  Partials     2173     2173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review March 28, 2024 09:31
@ngjaying ngjaying merged commit 4986d43 into lf-edge:master Mar 29, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants