Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support modify sqlSource field index value #2730

Merged
merged 17 commits into from
Apr 3, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 25, 2024

No description provided.

Signed-off-by: yisaer <[email protected]>
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 67.12329% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (c258a6a) to head (90d3032).

Files Patch % Lines
internal/server/rule_state.go 76.00% 12 Missing ⚠️
internal/topo/topo.go 0.00% 9 Missing ⚠️
internal/topo/node/source_node.go 33.33% 2 Missing ⚠️
internal/server/rest.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   63.17%   63.18%   +0.02%     
==========================================
  Files         346      347       +1     
  Lines       39322    39395      +73     
==========================================
+ Hits        24838    24891      +53     
- Misses      12315    12336      +21     
+ Partials     2169     2168       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying March 26, 2024 03:17
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer a general state read/write API, not specific to SQL index value.

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying March 27, 2024 05:29
Yisaer added 3 commits March 28, 2024 13:23
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
extensions/sources/sql/ext/sql.go Outdated Show resolved Hide resolved
Yisaer added 2 commits March 28, 2024 15:23
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying March 28, 2024 08:06
@Yisaer Yisaer requested a review from ngjaying April 3, 2024 03:33
@ngjaying ngjaying merged commit aaab86b into lf-edge:master Apr 3, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants