Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve EventDispatcherInterface typehint error with symfony 4.3.1 #668

Closed
wants to merge 1 commit into from
Closed

Resolve EventDispatcherInterface typehint error with symfony 4.3.1 #668

wants to merge 1 commit into from

Conversation

mickaelottmann
Copy link

No description provided.

@Webonaute
Copy link
Contributor

Webonaute commented Jun 26, 2019 •
edited
Loading

@mickaelottmann to preserve dispatch name, the code should be
$this->dispatcher->dispatch($event, Events::JWT_AUTHENTICATED);

@Webonaute
Copy link
Contributor

actualy, here is the right fix to keep compatibility.
#669

@Webonaute Webonaute mentioned this pull request Jun 26, 2019
Merged
@chalasr
Copy link
Collaborator

chalasr commented Jul 15, 2019

Closing in favor of #669 as explained, thank you for the PR.

@chalasr chalasr closed this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mickaelottmann @Webonaute @chalasr