Configuration options modified #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chalasr as discussed yesterday |
|
@Spomky I just opened #196 that makes the Sorry for that you worked on this here before. Could you please revert the changes you did that are done by #196? Also the StyleCI analysis doesn't pass, you should be able to fix it by running Thank you |
|
Here are the changes that need to be reverted:
|
This commit modifies the following configuration option: * the encryption_algorithm is renamed into signature_algorithm. Documentation is updated accordingly. This commit includes minor modifications on the service.xml file.
|
Hi @chalasr |
Merged
chalasr
added a commit
that referenced
this pull request
Sep 1, 2016
This PR was merged into the 2.0 branch. Discussion ---------- Next to #195 where we changed `encryption_algorithm` to `signature_algorithm`, this adapt the (forgotten) existing code, changing `encryptionAlgorithm` to `signatureAlgorithm` everywhere. 2.0 being not yet released, we must profit to ensure that the introduced features are following good practices, conventions and naming. @Spomky as you are quite aware of the good practices in term of encoding in general, it would be awesome if you could do a quick review of the terms we use in the corresponding part of our code base, especially on the `2.0` branch after #162. For instance I thought about `encryption_engine`, is it always correct in the contexts we use it? Otherwise, what about simply name it `engine`? That would give `encoder.engine` as option name. Let me know about your suggestions! Commits ------- a0b4430 Change encryptionAlgorithm to encryptionEngine Use 'crypto' term for keys
gzim324
pushed a commit
to gzim324/LexikJWTAuthenticationBundle
that referenced
this pull request
Jan 10, 2025
* Revert "Specific ocramius/package-versions version" * Try to fix Travis mongodb install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the following configuration option:
encryption_algorithmis renamed intosignature_algorithm.Documentation is updated accordingly.
This PR includes minor modifications on the service.xml file.