chore: add testrun for PHP 8.4. Fix implicit nullable parameter #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris53897
changed the title
|
PHP 8.4 is released, so should this pull request be merged? |
chalasr
approved these changes
Dec 3, 2024
|
Thanks for the PR and sorry for the delay, it's Symfony 7.2+SymfonyCon time of the year. I'm going to merge and release asap probably on Saturday during the hackday |
|
I wish you a good time at SymfonyCon |
|
Hey @chalasr, I hope you had a good time at SymfonyCon |
|
Thank you @Chris53897! |
|
@chalasr any chance these PHP 8.4 related changes could make it into a release? 😃 |
|
Can It be released please? spamming deprecations... |
|
Sorry for the delay! Here you go https://github.com/lexik/LexikJWTAuthenticationBundle/releases/tag/v3.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/lcobucci/jwt/blob/5.4.x/composer.json
Needs a release of lcobucci/jwt 5.4 => DONE
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated