Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1083. Fixed issue with option user_id_claim. #1133

Merged
merged 1 commit into from
Apr 11, 2023
Merged

#1083. Fixed issue with option user_id_claim. #1133

merged 1 commit into from
Apr 11, 2023

Conversation

koftikes
Copy link

@koftikes koftikes commented Mar 30, 2023

Fixed issue with configuration option user_id_claim

@chalasr
Copy link
Collaborator

chalasr commented Apr 1, 2023

Would you mind adding a testcase covering this change ? Happy to provide some guidance if needed

@koftikes
Copy link
Author

koftikes commented Apr 3, 2023

Yes, please.
What exactly test case you want to see?
in issue 1083(#1083) exist example.

@koftikes
Copy link
Author

koftikes commented Apr 6, 2023

@chalasr Hello. Any additional info?

@chalasr
Copy link
Collaborator

chalasr commented Apr 11, 2023

The patch looks good, I'll add the test on my own. Thanks a lot @koftikes

@chalasr
Copy link
Collaborator

chalasr commented Apr 11, 2023

Thank you @koftikes.

@chalasr chalasr merged commit af19e10 into lexik:2.x Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants