Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWTCookieProvider::createCookie does not set correct values when some params are provided false #1258

Closed
nuryagdym opened this issue Nov 29, 2024 · 0 comments
Closed

JWTCookieProvider::createCookie does not set correct values when some params are provided false #1258

nuryagdym opened this issue Nov 29, 2024 · 0 comments

Comments

@nuryagdym
Copy link

nuryagdym commented Nov 29, 2024 •
edited
Loading

$secure, $httpOnly, $partitioned params of JWTCookieProvider::createCookie are not used when they are false because of condition used.

issue exist on both 2.x and 3.x version.

Opened MR for 3.x branch, can also open another mr for 2.x if neccessary.
nuryagdym pushed a commit to nuryagdym/LexikJWTAuthenticationBundle that referenced this issue Nov 29, 2024
fix issue lexik#1258 JWTCookieProvider does set flags cookie flags wh…
e9f7fe1 
…en value is false
@nuryagdym nuryagdym mentioned this issue Nov 29, 2024
Merged
nuryagdym pushed a commit to nuryagdym/LexikJWTAuthenticationBundle that referenced this issue Nov 29, 2024
fix issue lexik#1258 JWTCookieProvider does set flags cookie flags wh…
d3650a1 
…en value is false
chalasr added a commit that referenced this issue Dec 14, 2024
@chalasr
bug #1259 fix issue #1258 JWTCookieProvider does set flags cookie fla…
d40886d 
…gs when va… (mustapayev)

This PR was merged into the 3.x branch.

Discussion
----------

fix issue #1258 JWTCookieProvider does set flags cookie flags when va…

fixes issue #1258

Commits
-------

d3650a1 fix issue #1258 JWTCookieProvider does set flags cookie flags when value is false
@chalasr chalasr closed this as completed Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chalasr @nuryagdym