Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ineffective git.depth option #32

Closed
wants to merge 1 commit into from

Conversation

epheien
Copy link
Contributor

@epheien epheien commented Jul 18, 2024

This is a simple solution to fix this issue, which is to only use it when options such as git branch are not specified, whereas previously this option was completely unavailable.

@lewis6991
Copy link
Owner

Hmm, I'm not sure if it is worth maintaining a depth option. We already use --filter=blob:none which mostly does the same thing and is much more robust.

@epheien
Copy link
Contributor Author

epheien commented Jul 19, 2024

It seems that when git version >= 2.19, --filter=blob:none works better than --depth=1.

I think there are two implementation plans:

  1. The git.depth option is not supported and remove it.
  2. Simple implementation of git.depth but not enabled by default.

@lewis6991
Copy link
Owner

Git 2.19 came out 5 years ago. Anyone that isn't on that can live with full checkouts.

@lewis6991
Copy link
Owner

Removed git.depth here: 897ee8f

@lewis6991 lewis6991 closed this Jul 25, 2024
@epheien epheien deleted the fix-git-depth branch July 25, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants