Add GitHub integration #839
Conversation
alexmarucci
force-pushed
the
gh-integration
branch
from
93521df to
1998b16
Compare
|
Hi @lewis6991, I hope PRs are welcomed. This is a feature I wanted for a while now, so I thought giving it a go. Let me know your thoughts, also I might need a hand with the failing tests. Unsure why they're failing to be fair. Thank you |
| @@ -75,9 +75,11 @@ require('gitsigns').setup { | |||
| virt_text = true, | |||
| virt_text_pos = 'eol', -- 'eol' | 'overlay' | 'right_align' | |||
| delay = 1000, | |||
| github_blame = false, | |||
There was a problem hiding this comment.
@lewis6991 should this be called something like use_github or something like that instead?
| • `<number>` | ||
| • `<author>` | ||
| • `<mergedAt>` or `<mergedAt:FORMAT>` | ||
| • `<title>` |
There was a problem hiding this comment.
As an improvement, we could expand this to the full list of fields that gh gives us instead? only nested fields are not supported yet
| if last_pr then | ||
| result = last_pr; | ||
| -- the parser does not support accessing keys like <author.name> | ||
| result.author = last_pr.author.name |
There was a problem hiding this comment.
<author.name> maybe that's something we could add? so we could just query the GH endpoint and pass down all the available fields
|
Hi. PRs are definitely welcome, however I have a relatively high bar for new features (just to be warned). I'll have a fair amount of feedback to give, but I'll need to test this first. Like everyone, I'm pretty busy, spread quite thin across several projects and only limited time to work on open source stuff so it might be a while until I can look at this properly. One thing I'll say now is that this feature must not affect the experience of the plugin on non-github repos and therefore should purely be additive. I'm also not so sure about adding another formatter field to the config. The formatter (string version) was added without the consideration of optional fields, whereas a single function can handle all cases. The plugin must also not try to call Other than that, this looks like a good start. 👍 |
Nice, thank you for your feedback. That's totally fine, and I think I got enough to make few adjustments already 👍 I will see if I get some time to look into the failing tests. In general, I see this as a starting point to make some progress on this feature following some directions from your side. Speak soon 👋 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Following up on the original PR #623
github_blameand github formatter config