This repository was archived by the owner on May 26, 2023. It is now read-only.
Use concatenation instead of path.join for URLs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using path.join adds backslashes when on Windows
|
Could someone take a look at this? It fixes important problems with this package when used on Windows. I can't upgrade to the latest version of this package because it is currently broken on Windows. |
lettertwo
added a commit
that referenced
this pull request
Nov 20, 2015
Use concatenation instead of path.join for URLs
|
@conradz Thank you for your incredible patience, I've finally gotten around to pulling this and publishing a new version (on npm). |
|
Thanks! ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this plugin on Windows, it currently always includes a
%5Cat the start of every URL in the manifest whenpublicPathis/. This obviously makes the appcache fail to load the specified assets.This change fixes this issue by concatenating the
publicPathand the asset URL instead of usingpath.join. Webpack (in its documentation) seems to expect a trailing slash on thepublicPath.path.joinis for file paths, not URLs since it uses the OS's path separator.