fix: restore permission selection with model options - #36
Merged
Merged
Conversation
Letta Code (agent-c2adbf5c-8419-4211-8cd8-3740db164974) Publish permissions as a category=mode session config option so ACP clients can render it alongside the model selector while retaining legacy session mode support. Co-authored-by: Cameron <cameron@pfiffer.org> 👾 Generated with [Letta Code](https://letta.com) Co-Authored-By: Letta Code <noreply@letta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configOptionsselector withcategory: "mode"modes/session/set_modepath for older ACP clientssession/set_config_optionto the adapter enforcement stateWhy
Zed 1.13 treats legacy
modesand modernconfigOptionsas mutually exclusive. Once letta-acp added a model config option, Zed retained the model selector and discarded the permission modes, removing the permission control from the composer.Validation
bun run check— 61 tests, typecheck, and buildbun run test:acpx— real ACP stdio client boundarysession/set_config_optionauto-allows a Bash approval without prompting👾 Generated with Letta Code