Skip to content

wfe: fix a race in orderForDisplay #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarongable merged 3 commits into from
May 21, 2025
Merged

wfe: fix a race in orderForDisplay #500

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ea0aea
wfe: fix a race in `orderForDisplay`
tgeoghegan May 20, 2025
27d9c17
explicitly construct copied order
tgeoghegan May 20, 2025
ad0cd48
improve comment
tgeoghegan May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions wfe/wfe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1840,8 +1840,22 @@ func (wfe *WebFrontEndImpl) orderForDisplay(
defer order.RUnlock()

// Copy the initial OrderRequest from the internal order object to mutate and
// use as the result.
result := order.Order
// use as the result. We have to make sure to copy the *contents* of the
// identifiers and authorizations slices and not the slices or the mutations
// below could mutate the order in the database, causing data races.
result := acme.Order{
Status: order.Order.Status,
Error: order.Order.Error,
Expires: order.Order.Expires,
Identifiers: slices.Clone(order.Order.Identifiers),
Profile: order.Order.Profile,
Finalize: order.Order.Finalize,
NotBefore: order.Order.NotBefore,
NotAfter: order.Order.NotAfter,
Authorizations: slices.Clone(order.Order.Authorizations),
Certificate: order.Order.Certificate,
Replaces: order.Order.Replaces,
}

// Randomize the order of the order authorization URLs as well as the order's
// identifiers. ACME draft Section 7.4 "Applying for Certificate Issuance"
Expand Down
Loading