Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: remove jmhodges/clock dependency. #231

Merged
merged 1 commit into from
Apr 12, 2019
Merged

dep: remove jmhodges/clock dependency. #231

merged 1 commit into from
Apr 12, 2019

Conversation

cpu
Copy link
Contributor

@cpu cpu commented Apr 12, 2019

It was inherited from Boulder but was never used anywhere in Pebble.

It was inherited from Boulder but was never used anywhere in Pebble.
@cpu cpu self-assigned this Apr 12, 2019
@cpu cpu merged commit 8bc2d56 into master Apr 12, 2019
@cpu cpu deleted the cpu-no-clock-dep branch April 12, 2019 16:38
@jsha
Copy link
Contributor

jsha commented Apr 12, 2019

I'm fine with this for now, since I think we shouldn't have dependencies and fields we're not currently using. But I'd like to stay open to the possibility we'll bring it back in the future. The ability to manipulate Boulder's notion of time has been very useful for our integration tests, and I suspect some clients will want to do similar in Pebble.

@cpu
Copy link
Contributor Author

cpu commented Apr 12, 2019

The ability to manipulate Boulder's notion of time has been very useful for our integration tests, and I suspect some clients will want to do similar in Pebble.

Maybe! I'm open to bringing it back (or something similar) in the future if there are tests being written that need it. Pebble doesn't do authorization reuse or ACME-CAA or any of the things that jump to mind where we've had to use fake time in Boulder. It would probably just be useful for testing expiration and there's likely a way to do that without needing all of the complexity of passing around a fake clock.

@jsha
Copy link
Contributor

jsha commented Apr 12, 2019

Yep! The main thing I'm thinking of here is that clients need to test how they behave when a certificate is near expiration. But I guess most clients are probably doing that by manipulating the client clock, and it doesn't really matter if they manipulate the server clock (though if they get back a certificate that doesn't have expected dates they might get into a renewal loop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants