Add sent/return value check to client.print() #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check and debug to client.print() in send_via_http() on sent bytes and fail if not all (or nothing) could be sent to the wifi client
TD-er
reviewed
Oct 31, 2018
clumsy-stefan
commented
Nov 1, 2018
Contributor
Author
clumsy-stefan
left a comment
clumsy-stefan
left a comment
There was a problem hiding this comment.
@TD-er agree, just let me know if I should change this accordingly or how you want to proceed?
Contributor
|
@clumsy-stefan please add just remark about size_t etc. |
Added comment to explain why the comparison is done to the length%256
Member
|
That's an elaborate explanation :) |
Contributor
Author
hmmm.... not sure how I have to interprete that? too much? Not enough? Wrong? or just a bit detailed' ;) do I need to change? |
Member
It was more than expected, but please don't change it. It is fine. :) |
Contributor
|
it's fine, for me client.print returns size_t not int could be enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check and debug to client.print() in send_via_http() on sent bytes and fail if not all (or nothing) could be sent to the wifi client.
See also discussion here #1957