Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null-safety #58

Merged
merged 5 commits into from
Apr 10, 2021
Merged

Migrate to null-safety #58

merged 5 commits into from
Apr 10, 2021

Conversation

ThexXTURBOXx
Copy link
Contributor

@ThexXTURBOXx ThexXTURBOXx commented Mar 29, 2021

This PR uses @John-Dormevil's branch https://github.com/John-Dormevil/value_layout_builder/tree/null-safety (see PR letsar/value_layout_builder#2) for now.

I will change this to a stable version as soon as it is merged.

Fixes #57

@ThexXTURBOXx
Copy link
Contributor Author

@letsar Thanks for merging letsar/value_layout_builder#2!

My branch is already updated to use the new version of value_layout_builder. So, a review would be highly appreciated :)

Copy link
Owner

@letsar letsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for this PR 🙂 ! Everthing seems fine except small minor changes.

lib/src/rendering/sliver_sticky_header.dart Outdated Show resolved Hide resolved
lib/src/widgets/sliver_sticky_header.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@ThexXTURBOXx
Copy link
Contributor Author

Very good eyes, thanks! :) I resolved the current discussions. Is there anything else you may have noticed? ^^

@ThexXTURBOXx ThexXTURBOXx requested a review from letsar April 10, 2021 19:36
Copy link
Owner

@letsar letsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support null safety
2 participants