Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Flutter 1.6.0 (new error formats) #26

Merged
merged 3 commits into from
May 23, 2019

Conversation

ened
Copy link
Contributor

@ened ened commented May 18, 2019

fixes #24

@cimplesid
Copy link

cimplesid commented May 19, 2019

[ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: type 'SliverHitTestResult' is not a subtype of type 'BoxHitTestResult'
E/flutter (28410): #0 RenderSliverStickyHeader.hitTestChildren
package:flutter_sticky_header/…/rendering/sliver_sticky_header.dart:273
after following your steps i m getting issue while taping on stick header

@ened
Copy link
Contributor Author

ened commented May 19, 2019

@cimplesid Updated the PR, please update your local copy and confirm errors are gone & functionality retained. Thx.

@cimplesid
Copy link

@cimplesid Updated the PR, please update your local copy and confirm errors are gone & functionality retained. Thx.

500% working thankyou @ened

@ened
Copy link
Contributor Author

ened commented May 23, 2019

@letsar hi - ok to merge & publish?

@cimplesid
Copy link

@letsar hi - ok to merge & publish?

ened can u look into another plugin called admob flutter it have issue in platform view and they are looking for maintainer for the project and i need that plugin asap problem with it is if it is implemented
in project then an edit on project dont work even after commenting the code so if u have time kindly look into it and @letsar merge the PR

@letsar
Copy link
Owner

letsar commented May 23, 2019

Thanks, I'll look at it

@letsar letsar merged commit b2f5cd1 into letsar:master May 23, 2019
@ened
Copy link
Contributor Author

ened commented Jun 6, 2019

@letsar could you cut a new major release to pub?

@ened
Copy link
Contributor Author

ened commented Aug 20, 2019

@letsar let's get a new release on pub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The argument type 'String' can't be assigned to the parameter type 'DiagnosticsNode'. - Flutter 1.5.9
3 participants