Skip to content

fix: deep link and UI cleanup for Figma integration#232

Merged
let-sunny merged 12 commits intomainfrom
fix/figma-comment-deeplink-v2
Mar 31, 2026
Merged

fix: deep link and UI cleanup for Figma integration#232
let-sunny merged 12 commits intomainfrom
fix/figma-comment-deeplink-v2

Conversation

@let-sunny
Copy link
Copy Markdown
Owner

@let-sunny let-sunny commented Mar 31, 2026

Summary

  • Deep link fix: Strip instance-internal path to top-level node (I175:7425;1442:7704node-id=175-7425)
  • UI cleanup: Remove lock icon from authorize modal, remove checkmark from Sent button

Test plan

  • pnpm test:run — 656 tests pass
  • Deep link navigates to correct node in Figma
  • Sent button shows "Sent" without checkmark

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved Figma deep link generation to correctly handle and process complex instance node identifiers used in comment workflows.
  • UI/UX Improvements

    • Simplified the success message shown after submitting Figma comments by removing decorative symbols.
    • Cleaned up the authorization modal by removing an unnecessary icon from the hint text for better visual clarity.

- Deep link: "I175:7425;1442:7704" → "node-id=175-7425"
- Remove lock SVG from authorize modal
- Remove checkmark from Sent button

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

Warning

Rate limit exceeded

@let-sunny has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bba7d5f5-49eb-49ed-afe1-1ca82311b69a

📥 Commits

Reviewing files that changed from the base of the PR and between 40a272b and dc8ed6e.

📒 Files selected for processing (4)
  • app/figma-plugin/src/ui.template.html
  • app/shared/styles.css
  • app/web/src/index.html
  • src/core/report-html/render.ts
📝 Walkthrough

Walkthrough

The PR removes visual indicators (SVG icon and checkmark character) from Figma-related UI elements and refines nodeId normalization in the deep-link builder by preprocessing instance-internal IDs and prefixes before formatting for deep links.

Changes

Cohort / File(s) Summary
Figma Comment UI Updates
app/web/src/index.html, src/core/report-html/index.ts
Removed SVG icon from hint text and changed success button label from 'Sent ✓' to 'Sent' in both the authorization modal and HTML report script.
Figma Deep-Link Node ID Processing
src/core/adapters/figma-url-parser.ts
Modified buildFigmaDeepLink to normalize nodeId via toCommentableNodeId (splitting instance-internal paths on ; and stripping leading I prefix) before replacing : with - for deep-link formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A checkmark hops away with grace,
The SVG icon finds new space,
Instance paths now cleanly split—
Deep links and comments perfectly knit! ✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: a deep link fix for Figma node ID handling and UI cleanup (icon and checkmark removal) across three files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/figma-comment-deeplink-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

@let-sunny let-sunny marked this pull request as ready for review March 31, 2026 13:33
let-sunny and others added 3 commits March 31, 2026 22:36
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@let-sunny let-sunny force-pushed the fix/figma-comment-deeplink-v2 branch from 5cde657 to 59d3f3f Compare March 31, 2026 13:39
let-sunny and others added 8 commits March 31, 2026 22:41
…tBody

Remove duplicate plugin footer, add version and Feedback/Share links
to the common footer in render.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Token generation guide moved above input
- Privacy note moved below Authorize button (smaller)
- Logout button removed (use Change token → clear input)
- Topbar button text changes to "Change token" after auth

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@let-sunny let-sunny force-pushed the fix/figma-comment-deeplink-v2 branch from 914dc17 to dc8ed6e Compare March 31, 2026 13:59
@let-sunny let-sunny merged commit e0a6b20 into main Mar 31, 2026
3 checks passed
@let-sunny let-sunny deleted the fix/figma-comment-deeplink-v2 branch March 31, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant