Skip to content

feat: structured violation messages + tab/rule-group report UI (#155) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
let-sunny merged 7 commits into from
Mar 29, 2026
Merged

feat: structured violation messages + tab/rule-group report UI (#155) #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3ca5255
feat: structured violation messages + tab/rule-group report UI (#155)
let-sunny Mar 29, 2026
c2232da
fix: tab interaction in plugin/web, gauge overflow, scroll affordance
let-sunny Mar 29, 2026
b1981c9
fix: tab scroll affordance for narrow viewport, clean dead CSS
let-sunny Mar 29, 2026
fbd05c6
fix: hide tab scrollbar, restore fade gradient on narrow viewport
let-sunny Mar 29, 2026
9395064
fix: Stage 1 dedupe — only mark seen after confirming first frame
let-sunny Mar 29, 2026
1367a45
fix: review feedback — fade scope, comment message, idempotent init
let-sunny Mar 29, 2026
d48dfbc
fix: HTML5 summary content model, initial gauge active state
let-sunny Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/figma-plugin/src/ui.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ <h2>Ready to analyze</h2>
maxDepth: result.maxDepth,
});
el.className = 'visible';
CanICode.initReportInteractions(el);
document.getElementById('footer').style.display = '';
}

Expand Down
222 changes: 145 additions & 77 deletions app/shared/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ body {
================================================================ */

/* ---- Details/summary reset ---- */
.rpt-cat > summary::-webkit-details-marker,
.rpt-rule > summary::-webkit-details-marker,
.rpt-issue > summary::-webkit-details-marker { display: none; }
.rpt-cat > summary::marker,
.rpt-rule > summary::marker,
.rpt-issue > summary::marker { content: ""; }
.rpt-cat > summary,
.rpt-rule > summary,
.rpt-issue > summary { list-style: none; }

/* ---- Overall Score ---- */
Expand Down Expand Up @@ -115,10 +115,12 @@ body {
display: flex;
flex-direction: column;
align-items: center;
position: relative;
cursor: pointer;
text-decoration: none;
color: var(--fg);
background: none;
border: none;
padding: 4px;
transition: opacity 0.15s;
}
.rpt-gauge-item:hover { opacity: 0.8; }
Expand Down Expand Up @@ -270,25 +272,80 @@ body {
}
.rpt-opps-link:hover { color: var(--fg); }

/* ---- Categories ---- */
.rpt-cats > * + * {
margin-top: 12px;
/* ---- Category Tabs (shadcn pill style) ---- */
.rpt-tabs {
margin-bottom: 24px;
position: relative;
}
.rpt-cat {
overflow: hidden;
@media (max-width: 600px) {
.rpt-tab-list::after {
content: "";
position: sticky;
right: 0;
width: 40px;
min-height: 100%;
background: linear-gradient(to right, transparent, var(--bg));
pointer-events: none;
flex-shrink: 0;
margin-left: -40px;
}
}
.rpt-cat-header {
padding: 14px 20px;
.rpt-tab-list {
display: flex;
align-items: center;
gap: 12px;
gap: 4px;
padding: 4px;
background: var(--bg);
border: 1px solid var(--border);
border-radius: var(--radius);
overflow-x: auto;
white-space: nowrap;
-webkit-overflow-scrolling: touch;
}
.rpt-tab-list::-webkit-scrollbar { display: none; }
.rpt-tab-list { scrollbar-width: none; }
.rpt-tab {
padding: 6px 12px;
font-size: 13px;
font-weight: 500;
color: var(--fg-muted);
background: transparent;
border: none;
border-radius: 6px;
cursor: pointer;
transition: background 0.15s;
user-select: none;
transition: all 0.15s;
white-space: nowrap;
flex-shrink: 0;
}
.rpt-tab:hover { color: var(--fg); background: rgba(0,0,0,0.04); }
.rpt-tab.active {
color: var(--fg);
background: var(--card);
box-shadow: 0 1px 2px rgba(0,0,0,0.06);
}
.rpt-tab-count {
font-size: 11px;
color: var(--fg-muted);
margin-left: 2px;
}
.rpt-tab.active .rpt-tab-count { color: var(--fg-muted); }
.rpt-tab-panel { display: none; padding-top: 16px; }
.rpt-tab-panel.active { display: block; }
.rpt-cat-empty {
padding: 24px 20px;
font-size: 14px;
color: var(--green);
font-weight: 500;
text-align: center;
}

/* ---- Gauge item active highlight ---- */
.rpt-gauge-item.active {
opacity: 1;
background: rgba(0,0,0,0.04);
border-radius: var(--radius);
}
.rpt-cat-header:hover { background: rgba(0,0,0,0.02); }

/* Score badge */
/* ---- Score badge ---- */
.rpt-badge {
display: inline-flex;
align-items: center;
Expand All @@ -306,65 +363,76 @@ body {
.rpt-badge.score-amber { background: var(--amber-bg); color: #b45309; border-color: rgba(245,158,11,0.2); }
.rpt-badge.score-red { background: var(--red-bg); color: #b91c1c; border-color: rgba(239,68,68,0.2); }

.rpt-cat-info {
flex: 1;
min-width: 0;
}
.rpt-cat-name {
font-size: 14px;
font-weight: 600;
/* ---- Rule Section ---- */
.rpt-tab-panel > .rpt-rule + .rpt-rule {
margin-top: 12px;
}
.rpt-cat-desc {
font-size: 12px;
color: var(--fg-muted);
.rpt-rule {
overflow: hidden;
}
.rpt-cat-count {
font-size: 12px;
color: var(--fg-muted);
white-space: nowrap;
.rpt-rule-header {
padding: 14px 20px;
display: flex;
align-items: flex-start;
gap: 12px;
cursor: pointer;
user-select: none;
transition: background 0.15s;
}
.rpt-cat-chevron {
.rpt-rule-header:hover { background: rgba(0,0,0,0.02); }
.rpt-rule-chevron {
width: 16px;
height: 16px;
color: var(--fg-muted);
transition: transform 0.2s;
flex-shrink: 0;
margin-top: 2px;
margin-left: auto;
}
.rpt-cat[open] > .rpt-cat-header .rpt-cat-chevron {
.rpt-rule[open] > .rpt-rule-header .rpt-rule-chevron {
transform: rotate(180deg);
}
.rpt-cat-body {
border-top: 1px solid var(--border);
}
.rpt-cat-empty {
padding: 16px 20px;
.rpt-rule-name {
font-size: 14px;
color: var(--green);
font-weight: 500;
}

/* ---- Severity Group ---- */
.rpt-sev-group {
padding: 12px 20px;
font-weight: 600;
display: block;
}
.rpt-sev-header {
.rpt-rule-meta {
font-size: 12px;
color: var(--fg-muted);
display: flex;
align-items: center;
gap: 8px;
margin-bottom: 8px;
gap: 6px;
margin-top: 2px;
}
.rpt-sev-label {
font-size: 11px;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.04em;
.rpt-rule-title {
display: block;
flex: 1;
min-width: 0;
}
.rpt-sev-count {
.rpt-rule-info {
display: block;
padding: 8px 0 4px;
font-size: 12px;
color: var(--fg-muted);
margin-left: auto;
line-height: 1.6;
margin-top: 8px;
}
.rpt-rule-info-line {
display: block;
}
.rpt-rule-info-line + .rpt-rule-info-line {
margin-top: 4px;
}
.rpt-rule-info strong {
color: var(--fg);
font-weight: 500;
}
.rpt-sev-issues > * + * {
.rpt-rule-issues {
padding: 8px 12px;
border-top: 1px solid var(--border);
}
.rpt-rule-issues > * + * {
margin-top: 4px;
}

Expand All @@ -379,16 +447,11 @@ body {
align-items: center;
gap: 10px;
padding: 8px 12px;
font-size: 14px;
font-size: 13px;
cursor: pointer;
transition: background 0.15s;
}
.rpt-issue-header:hover { background: rgba(0,0,0,0.02); }
.rpt-issue-name {
font-weight: 500;
white-space: nowrap;
flex-shrink: 0;
}
.rpt-issue-msg {
color: var(--fg-muted);
font-size: 12px;
Expand All @@ -415,28 +478,32 @@ body {
padding: 12px;
background: #fafafa;
border-top: 1px solid var(--border);
font-size: 14px;
font-size: 13px;
}
.rpt-issue-body > * + * {
margin-top: 8px;
margin-top: 6px;
}
.rpt-issue-suggestion {
font-weight: 500;
color: var(--fg);
}
.rpt-issue-guide {
font-size: 12px;
color: var(--fg-muted);
padding: 4px 8px;
background: var(--blue-bg);
border-radius: 4px;
display: inline-block;
}
.rpt-issue-guide::before {
content: "ℹ️ ";
}
.rpt-issue-path {
font-family: var(--font-mono);
font-size: 12px;
color: var(--fg-muted);
word-break: break-all;
}
.rpt-issue-info {
color: var(--fg-muted);
line-height: 1.6;
}
.rpt-issue-info > * + * {
margin-top: 4px;
}
.rpt-issue-info strong {
color: var(--fg);
font-weight: 500;
}
.rpt-issue-actions {
display: flex;
align-items: center;
Expand Down Expand Up @@ -494,11 +561,12 @@ body {
.rpt-gauges { padding: 16px; }
.rpt-summary-inner { gap: 12px; }
.rpt-summary-total { border-left: none; padding-left: 0; }
.rpt-tab-list { gap: 8px; padding: 4px 12px; }
.rpt-tab { padding: 6px 14px; }
.rpt-opps-item { padding: 10px 16px; gap: 10px; }
.rpt-opps-bar-wrap { width: 80px; }
.rpt-opps-link { font-size: 11px; }
.rpt-cat-header { padding: 10px 14px; gap: 8px; }
.rpt-sev-group { padding: 10px 14px; }
.rpt-rule-header { padding: 10px 14px; gap: 8px; }
.rpt-issue-header { padding: 6px 10px; gap: 6px; font-size: 12px; }
.rpt-issue-body { padding: 10px; font-size: 12px; }
}
Expand Down
1 change: 1 addition & 0 deletions app/web/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ <h1>Analyze your Figma designs</h1>
figmaToken: getToken() || undefined,
});
el.classList.add('visible');
CanICode.initReportInteractions(el);
el.scrollIntoView({ behavior: 'smooth', block: 'start' });
}

Expand Down
2 changes: 1 addition & 1 deletion src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export {
} from "./core/ui-helpers.js";

// Report rendering (shared with web/plugin)
export { renderReportBody } from "./core/report-html/render.js";
export { renderReportBody, initReportInteractions } from "./core/report-html/render.js";
export type { ReportData } from "./core/report-html/render.js";

// Import rules to register them with the global registry
Expand Down
4 changes: 2 additions & 2 deletions src/core/contracts/category.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ export const CategorySchema = z.enum([
"responsive-critical",
"code-quality",
"token-management",
"interaction",
"minor",
"interaction",
]);

export type Category = z.infer<typeof CategorySchema>;
Expand All @@ -18,6 +18,6 @@ export const CATEGORY_LABELS: Record<Category, string> = {
"responsive-critical": "Responsive Critical",
"code-quality": "Code Quality",
"token-management": "Token Management",
"interaction": "Interaction",
"minor": "Minor",
"interaction": "Interaction",
};
2 changes: 2 additions & 0 deletions src/core/contracts/rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ export interface RuleViolation {
nodeId: string;
nodePath: string;
message: string;
suggestion: string;
guide?: string;
}

/**
Expand Down
Loading
Loading