Skip to content

feat: add ablation Phase 1 execution script #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
let-sunny merged 30 commits into from
Mar 27, 2026
Merged

feat: add ablation Phase 1 execution script #143

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d95c3ad
feat: add ablation Phase 1 execution script (#130)
let-sunny Mar 27, 2026
d802019
fix: address all 5 review findings on ablation script
let-sunny Mar 27, 2026
1d38f70
fix: address remaining 4 review findings on ablation script
let-sunny Mar 27, 2026
3137ca7
fix: address blocking/medium review findings on ablation script
let-sunny Mar 27, 2026
219308c
fix: final 3 review findings — RunResult metadata, HTML priority, aut…
let-sunny Mar 27, 2026
ad2dce8
fix: widen config version hash to all result-affecting source files
let-sunny Mar 27, 2026
42bd1b3
fix: strict RUNS validation, lower HTML threshold, empty fixture guard
let-sunny Mar 27, 2026
7ff7a41
fix: distinguish parse failure in logs, track skipped fixtures in sum…
let-sunny Mar 27, 2026
b872833
fix: add run context and execution metadata for traceability
let-sunny Mar 27, 2026
d131f27
fix: include run-phase1.ts in config hash, rename misses to newCalls
let-sunny Mar 27, 2026
61d4107
fix: use cacheHits directly for console output clarity
let-sunny Mar 27, 2026
2533e38
fix: similarity display, tie-break sort, fixture hash in cache, resul…
let-sunny Mar 27, 2026
5e28731
fix: add retry with exponential backoff for 429/529 API errors
let-sunny Mar 27, 2026
01742a1
fix: use local Inter font instead of Google Fonts CDN
let-sunny Mar 27, 2026
0307c25
fix: remove // filename: prefix from HTML before rendering
let-sunny Mar 27, 2026
68ab026
fix: strip <script> tags from model HTML before rendering
let-sunny Mar 27, 2026
9ae7067
fix: flip ΔT sign for correct tie-break, validate fixture names
let-sunny Mar 27, 2026
512907a
fix: SVG mapping mismatch, parent names, crop, sanitization, coreFiles
let-sunny Mar 27, 2026
5e71f09
feat: emit position: absolute/relative for absolutely positioned nodes
let-sunny Mar 27, 2026
840f15e
fix: skip width: 100% when flex-grow: 1 is set (prevents wrap layout …
let-sunny Mar 27, 2026
952d9c4
fix: emit align-items: flex-start as Figma default (CSS default is st…
let-sunny Mar 27, 2026
4bc2ba2
chore: rebuild desktop-product-detail with parent-named vectors
let-sunny Mar 27, 2026
b8e53af
chore: rebuild all 23 remaining fixtures with parent-named vectors
let-sunny Mar 27, 2026
0b069b8
fix: download original image fills instead of node renders
let-sunny Mar 27, 2026
f508df5
fix: prevent position conflict, isolate per-run failures
let-sunny Mar 27, 2026
86c86a2
fix: increase MAX_TOKENS to 32000, handle unclosed code blocks
let-sunny Mar 27, 2026
4f16b34
fix: use streaming API to avoid 10-minute timeout
let-sunny Mar 27, 2026
a6cdb68
fix: skip color-values and typography from ablation (trivially obvious)
let-sunny Mar 27, 2026
ab689dc
fix: skip hover-interaction-states from ablation (trivially obvious)
let-sunny Mar 27, 2026
aa89f3e
fix: skip overflow-text-behavior from ablation (trivially obvious + l…
let-sunny Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added assets/fonts/Inter.var.woff2
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions fixtures/desktop-product-detail/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"fileKey": "pNmINk52N1oRQD0q7jAxOf",
"name": "Simple Design System (Community)",
"lastModified": "2026-03-27T13:37:11Z",
"version": "2335620422297920205",
"lastModified": "2026-03-27T15:54:42Z",
"version": "2335661297513016315",
"document": {
"id": "175:8591",
"name": "Platform=Desktop",
Expand Down Expand Up @@ -6680,7 +6680,7 @@
"layoutWrap": "NO_WRAP",
"clipsContent": false,
"absoluteBoundingBox": {
"x": 21459,
"x": 21690,
"y": 160.5,
"width": 47,
"height": 32
Expand Down Expand Up @@ -6757,7 +6757,7 @@
"horizontal": "LEFT"
},
"absoluteBoundingBox": {
"x": 21467,
"x": 21698,
"y": 168.5,
"width": 31,
"height": 16
Expand Down
Binary file removed fixtures/desktop-product-detail/screenshot-1920.png
View file
Open in desktop
Binary file not shown.
0 ...desktop-product-detail/vectors/icon-2.svg → ...ct-detail/vectors/chevron-down-icon-2.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-3.svg → ...duct-detail/vectors/chevron-down-icon.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-4.svg → ...roduct-detail/vectors/chevron-up-icon.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-21.svg → ...p-product-detail/vectors/figma-icon-2.svg
View file
Open in desktop
File renamed without changes
0 ...s/desktop-product-detail/vectors/icon.svg → ...top-product-detail/vectors/figma-icon.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-5.svg → ...top-product-detail/vectors/heart-icon.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-25.svg → ...-product-detail/vectors/linkedin-icon.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-23.svg → ...ct-detail/vectors/logo-instagram-icon.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-24.svg → ...duct-detail/vectors/logo-youtube-icon.svg
View file
Open in desktop
File renamed without changes
86 changes: 43 additions & 43 deletions fixtures/desktop-product-detail/vectors/mapping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
{
"I175:8312;2299:23059;11:11514;6:10368": "icon.svg",
"I175:8312;2299:23505;11:11514;6:10493": "icon-2.svg",
"I175:8312;189:27030": "icon-3.svg",
"I175:8312;18:9402;18:9047;34:12128;68:16010": "icon-4.svg",
"I175:8312;18:9402;18:9047;34:12130;68:16114": "icon-5.svg",
"I175:8312;18:9402;18:9048;34:12124;68:16010": "icon-6.svg",
"I175:8312;18:9402;18:9048;34:12126;68:16114": "icon-7.svg",
"I175:8313;189:27361;315:32303;68:16114": "icon-8.svg",
"I175:8313;2236:15771;565:15194;68:15644": "icon-9.svg",
"I175:8313;2236:15781;565:15194;68:15644": "icon-10.svg",
"I175:8313;2236:15699;9762:428;68:16010": "icon-11.svg",
"I175:8313;2236:15699;9762:430;68:16114": "icon-12.svg",
"I175:8313;375:13573;7753:4753;149:9553;7758:11236": "icon-13.svg",
"I175:8313;375:13573;7753:4747;149:9477;7758:11218": "icon-14.svg",
"I175:8313;375:13573;7753:4760;149:9477;7758:11218": "icon-15.svg",
"I175:8313;375:13573;7753:4766;149:9477;7758:11218": "icon-16.svg",
"I175:8313;375:13573;7753:4772;149:9477;7758:11218": "icon-17.svg",
"I175:8313;375:13573;297:8584;149:9477;7758:11218": "icon-18.svg",
"I175:8313;375:13573;297:8749;149:9477;7758:11218": "icon-19.svg",
"I175:8313;375:13573;297:8939;149:9477;7758:11218": "icon-20.svg",
"I175:8313;2236:15844;11:11510;68:15810": "icon-21.svg",
"I175:8315;2236:16107;638:14361;7758:12316": "icon-22.svg",
"I175:8315;2236:16107;638:14362;7758:12316": "icon-23.svg",
"I175:8315;2236:16107;638:14363;7758:12316": "icon-24.svg",
"I175:8315;2236:16107;638:14364;7758:12316": "icon-25.svg",
"I175:8315;2236:16107;638:14365;7758:12316": "icon-26.svg",
"I175:8315;2236:16130;638:14361;7758:12316": "icon-27.svg",
"I175:8315;2236:16130;638:14362;7758:12316": "icon-28.svg",
"I175:8315;2236:16130;638:14363;7758:12316": "icon-29.svg",
"I175:8315;2236:16130;638:14364;7758:12316": "icon-30.svg",
"I175:8315;2236:16130;638:14365;7758:12316": "icon-31.svg",
"I175:8315;2236:16153;638:14361;7758:12316": "icon-32.svg",
"I175:8315;2236:16153;638:14362;7758:12316": "icon-33.svg",
"I175:8315;2236:16153;638:14363;7758:12316": "icon-34.svg",
"I175:8315;2236:16153;638:14364;7758:12316": "icon-35.svg",
"I175:8315;2236:16153;638:14365;7758:12316": "icon-36.svg",
"I175:8316;2236:20307;197:19730;9762:428;68:16010": "icon-37.svg",
"I175:8316;2236:20307;197:19730;9762:430;68:16114": "icon-38.svg",
"I175:8318;189:27260": "icon-39.svg",
"I175:8318;325:12863": "icon-40.svg",
"I175:8318;325:12999": "icon-41.svg",
"I175:8318;325:13120": "icon-42.svg",
"I175:8318;325:12717": "icon-43.svg"
"I175:8312;2299:23059;11:11514;6:10368": "menu-16-icon.svg",
"I175:8312;2299:23505;11:11514;6:10493": "x-16-icon.svg",
"I175:8312;189:27030": "figma-icon.svg",
"I175:8312;18:9402;18:9047;34:12128;68:16010": "star-icon.svg",
"I175:8312;18:9402;18:9047;34:12130;68:16114": "x-icon.svg",
"I175:8312;18:9402;18:9048;34:12124;68:16010": "star-icon-2.svg",
"I175:8312;18:9402;18:9048;34:12126;68:16114": "x-icon-2.svg",
"I175:8313;189:27361;315:32303;68:16114": "x-icon-3.svg",
"I175:8313;2236:15771;565:15194;68:15644": "chevron-down-icon.svg",
"I175:8313;2236:15781;565:15194;68:15644": "chevron-down-icon-2.svg",
"I175:8313;2236:15699;9762:428;68:16010": "star-icon-3.svg",
"I175:8313;2236:15699;9762:430;68:16114": "x-icon-4.svg",
"I175:8313;375:13573;7753:4753;149:9553;7758:11236": "chevron-up-icon.svg",
"I175:8313;375:13573;7753:4747;149:9477;7758:11218": "chevron-down-icon-3.svg",
"I175:8313;375:13573;7753:4760;149:9477;7758:11218": "chevron-down-icon-4.svg",
"I175:8313;375:13573;7753:4766;149:9477;7758:11218": "chevron-down-icon-5.svg",
"I175:8313;375:13573;7753:4772;149:9477;7758:11218": "chevron-down-icon-6.svg",
"I175:8313;375:13573;297:8584;149:9477;7758:11218": "chevron-down-icon-7.svg",
"I175:8313;375:13573;297:8749;149:9477;7758:11218": "chevron-down-icon-8.svg",
"I175:8313;375:13573;297:8939;149:9477;7758:11218": "chevron-down-icon-9.svg",
"I175:8313;2236:15844;11:11510;68:15810": "heart-icon.svg",
"I175:8315;2236:16107;638:14361;7758:12316": "star-icon-4.svg",
"I175:8315;2236:16107;638:14362;7758:12316": "star-icon-5.svg",
"I175:8315;2236:16107;638:14363;7758:12316": "star-icon-6.svg",
"I175:8315;2236:16107;638:14364;7758:12316": "star-icon-7.svg",
"I175:8315;2236:16107;638:14365;7758:12316": "star-icon-8.svg",
"I175:8315;2236:16130;638:14361;7758:12316": "star-icon-9.svg",
"I175:8315;2236:16130;638:14362;7758:12316": "star-icon-10.svg",
"I175:8315;2236:16130;638:14363;7758:12316": "star-icon-11.svg",
"I175:8315;2236:16130;638:14364;7758:12316": "star-icon-12.svg",
"I175:8315;2236:16130;638:14365;7758:12316": "star-icon-13.svg",
"I175:8315;2236:16153;638:14361;7758:12316": "star-icon-14.svg",
"I175:8315;2236:16153;638:14362;7758:12316": "star-icon-15.svg",
"I175:8315;2236:16153;638:14363;7758:12316": "star-icon-16.svg",
"I175:8315;2236:16153;638:14364;7758:12316": "star-icon-17.svg",
"I175:8315;2236:16153;638:14365;7758:12316": "star-icon-18.svg",
"I175:8316;2236:20307;197:19730;9762:428;68:16010": "star-icon-19.svg",
"I175:8316;2236:20307;197:19730;9762:430;68:16114": "x-icon-5.svg",
"I175:8318;189:27260": "figma-icon-2.svg",
"I175:8318;325:12863": "x-logo-icon.svg",
"I175:8318;325:12999": "logo-instagram-icon.svg",
"I175:8318;325:13120": "logo-youtube-icon.svg",
"I175:8318;325:12717": "linkedin-icon.svg"
}
0 ...esktop-product-detail/vectors/icon-10.svg → ...p-product-detail/vectors/star-icon-10.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-11.svg → ...p-product-detail/vectors/star-icon-11.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-12.svg → ...p-product-detail/vectors/star-icon-12.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-13.svg → ...p-product-detail/vectors/star-icon-13.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-14.svg → ...p-product-detail/vectors/star-icon-14.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-15.svg → ...p-product-detail/vectors/star-icon-15.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-16.svg → ...p-product-detail/vectors/star-icon-16.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-17.svg → ...p-product-detail/vectors/star-icon-17.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-18.svg → ...p-product-detail/vectors/star-icon-18.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-19.svg → ...op-product-detail/vectors/star-icon-4.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-20.svg → ...op-product-detail/vectors/star-icon-5.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-6.svg → ...op-product-detail/vectors/star-icon-6.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-7.svg → ...op-product-detail/vectors/star-icon-7.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-8.svg → ...op-product-detail/vectors/star-icon-8.svg
View file
Open in desktop
File renamed without changes
0 ...desktop-product-detail/vectors/icon-9.svg → ...op-product-detail/vectors/star-icon-9.svg
View file
Open in desktop
File renamed without changes
0 ...esktop-product-detail/vectors/icon-22.svg → ...op-product-detail/vectors/x-logo-icon.svg
View file
Open in desktop
File renamed without changes
Loading
Loading