-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build #46
Update build #46
Conversation
SuperQ
commented
Aug 18, 2024
- Update Go matrix to latest 3 versions.
- Update minimum Go version to 1.21.
- Update golangci-lint version.
- Update GitHub actions.
- Pin GitHub actions to hash, as recommended by OSSF.
I don't see why you need to specify a git commit ID for the actions. Is there any reason why you not just using |
Pinning is generally recommended by the OSSF. Dependabot and similar will keep them up-to-date. |
* Update Go matrix to latest 3 versions. * Update minimum Go version to 1.21. * Update golangci-lint version. * Update GitHub actions. * Pin GitHub actions to hash, as recommended by OSSF. Signed-off-by: SuperQ <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 81.75% 82.37% +0.61%
==========================================
Files 7 5 -2
Lines 411 329 -82
==========================================
- Hits 336 271 -65
+ Misses 60 43 -17
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Ping, this would be nice to have to improve supply chain security. |
@SuperQ Sorry, didn't see your reply until just now. Hmm, didn't know dependabot handles commit IDs. Thanks! |
Thanks for building this library. I'm thinking about using it here. Time to cut a v1.1.0? |
@SuperQ Yes, but not right now. I know better than to cut a release when I'm about to go to bed... |
done |