Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build #46

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update build #46

merged 1 commit into from
Aug 27, 2024

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Aug 18, 2024

  • Update Go matrix to latest 3 versions.
  • Update minimum Go version to 1.21.
  • Update golangci-lint version.
  • Update GitHub actions.
  • Pin GitHub actions to hash, as recommended by OSSF.

@lestrrat
Copy link
Collaborator

I don't see why you need to specify a git commit ID for the actions. Is there any reason why you not just using v4 or v5 or whatever?

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 19, 2024

Pinning is generally recommended by the OSSF. Dependabot and similar will keep them up-to-date.

* Update Go matrix to latest 3 versions.
* Update minimum Go version to 1.21.
* Update golangci-lint version.
* Update GitHub actions.
* Pin GitHub actions to hash, as recommended by OSSF.

Signed-off-by: SuperQ <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (b0b9070) to head (26f4f46).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   81.75%   82.37%   +0.61%     
==========================================
  Files           7        5       -2     
  Lines         411      329      -82     
==========================================
- Hits          336      271      -65     
+ Misses         60       43      -17     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 27, 2024

Ping, this would be nice to have to improve supply chain security.

@lestrrat
Copy link
Collaborator

@SuperQ Sorry, didn't see your reply until just now. Hmm, didn't know dependabot handles commit IDs.
I'll take your word for it.

Thanks!

@lestrrat lestrrat merged commit 0a7b59d into lestrrat-go:master Aug 27, 2024
6 checks passed
@SuperQ SuperQ deleted the build branch August 27, 2024 12:29
@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 27, 2024

Thanks for building this library. I'm thinking about using it here.

Time to cut a v1.1.0?

@lestrrat
Copy link
Collaborator

@SuperQ Yes, but not right now. I know better than to cut a release when I'm about to go to bed...
Made myself a reminder to take a look in 12 hours :)
image

@lestrrat
Copy link
Collaborator

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants