Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change travisCI to Github Actions #172

Merged
merged 16 commits into from
Apr 24, 2020
Merged

Change travisCI to Github Actions #172

merged 16 commits into from
Apr 24, 2020

Conversation

sonatard
Copy link
Contributor

@sonatard sonatard commented Apr 24, 2020 •
edited
Loading

  • Update golangci-lint v1.25.0
  • Change travisCI to Github Actions
  • Executing Github Actions on this PR
  • Use imports.Process() instead of format.Source()

@sonatard sonatard marked this pull request as ready for review April 24, 2020 05:34
@sonatard sonatard changed the title Change travisCI to Github Actions [WIP] Change travisCI to Github Actions Apr 24, 2020
@sonatard sonatard marked this pull request as draft April 24, 2020 05:35
@sonatard
Copy link
Contributor Author

あれ Github Actions動かない

@sonatard
Copy link
Contributor Author

@lestrrat SettingでGithub Actionsが有効になっているか確認して頂いてもいいですか？
(Actionsタブ表示されているので、恐らく有効だとは思うのですが...

スクリーンショット 2020-04-24 14 44 46

@lestrrat
Copy link
Collaborator

もともと有効になってた予感！

image

@sonatard
Copy link
Contributor Author

ありがとうございます 👍
他の原因追ってみます！

@sonatard
Copy link
Contributor Author

Github Actions動かない件 解決しました 462be2e

@sonatard sonatard marked this pull request as ready for review April 24, 2020 08:03
@lestrrat
Copy link
Collaborator

462be2e のコミットメッセージがYAML MUST DIEじゃないのが残念w

@sonatard
Copy link
Contributor Author

@lestrrat imports.Processの件も無事解決しました　レビューお願いしますー！

@sonatard sonatard changed the title [WIP] Change travisCI to Github Actions Change travisCI to Github Actions Apr 24, 2020
lestrrat
lestrrat reviewed Apr 24, 2020
View reviewed changes
.github/workflows/ci.yml Outdated
runs-on: ubuntu-latest
strategy:
matrix:
go: [ '1.14', '1.13' ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go tipもテストしたいです！（tipがあることで 新しい機能でぶっ壊れた、いたいなのに追従できるので）

actions/setup-go#21 (comment)

lestrrat
lestrrat approved these changes Apr 24, 2020
View reviewed changes
Copy link
Collaborator

@lestrrat lestrrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tip だけどうにかなるとうれしい。あとはLGTMです！

@sonatard
Copy link
Contributor Author

@lestrrat 無事tipで動きました！

PATH通すのには単純にexportするのではなくGithub Actions固有の方言が必要でした

          echo "::set-env name=GOROOT::$HOME/gotip"
          echo "::add-path::$HOME/gotip/bin"
          echo "::add-path::$(go env GOPATH)/bin"

https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable

@lestrrat
Copy link
Collaborator

ありがたや〜ありがたや〜

@lestrrat lestrrat merged commit 6f8aa93 into lestrrat-go:master Apr 24, 2020
@sonatard sonatard deleted the gh-actions branch April 24, 2020 12:06
@sonatard
Copy link
Contributor Author

レビューありがとうございましたー！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lestrrat lestrrat lestrrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonatard @lestrrat