Conversation
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Transformers v5 deprecates the
use_fastimage-processor selector, but Qwen3.5 dense and MoE processing currently inherit a Qwen3-VL initialization path that injectsuse_fast=Trueeven when the caller did not specify it. This produces a startup warning for Qwen3.5 and Qwen3.6 checkpoints.The explicit default was needed when Qwen3-VL support targeted Transformers 4.x. vLLM now requires Transformers 5.5.3 or newer, where omitting the selector chooses
torchvisionfor Qwen's image processor when available and falls back topilotherwise. This is the same backend behavior as the formeruse_fast=Truedefault for Qwen.Changes
get_hf_processoronly for Qwen3.5 dense and MoE processing info so vLLM no longer injects a deprecated default.use_fastvalues.A direct replacement with top-level
backend="torchvision"is intentionally not used.Qwen3VLProcessorforwards top-level initialization kwargs to both image and video sub-processors, and its video processor does not accept that backend selector.Validation
10 passedintests/models/multimodal/processing/test_qwen3_5.py.5 passed, 369 deselectedintests/models/test_registry.py -k Qwen3_5.torchvisionimage backend, image configuration digest, and video configuration digest before and after omitting the forced default; the deprecated warning was absent only on the new default path.ruff check,ruff format --check,py_compile, andgit diff --checkpassed.The full vLLM test suite was not run.