Conversation
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
lesj0610
marked this pull request as ready for review
June 25, 2026 00:53
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
…-kv-pools-20260625 # Conflicts: # vllm/v1/core/kv_cache_manager.py Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: lesj0610 <lesj0610@users.noreply.github.com>
lesj0610
force-pushed
the
lesj/request-constant-kv-pools-20260625
branch
from
August 20, 2026 12:26
d727610 to
4a6fc38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix KV cache sizing for hybrid models that combine token-proportional attention KV with request-bound KV groups such as Mamba. The startup sizing path now accounts for the fixed request-bound blocks consumed from the shared BlockPool, and the auto-fit path reserves the BlockPool null block so derived capacity matches runtime admission.
The implementation keeps request-bound groups in the shared pool. That lets inactive request slots remain available to token KV instead of reserving a dedicated request-constant pool that this fix does not need. The PR also removes the inactive dedicated-pool fallback so the changed code path is the one that is actually exercised.
AI assistance: Codex was used during implementation and PR preparation; the submitter reviewed the changes.
Test Plan
Test Result
Syntax, lint, format, and whitespace checks:
Result: passed.
Targeted tests:
Result:
74 passed.Commit hooks also passed for the latest cleanup commit, including ruff, format, mypy, SPDX, config validation, and related repository checks.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Not needed; this is an internal KV cache sizing fix.