Conversation
lesj0610
force-pushed
the
lesj/nvfp4-slot-mapping-kv-cache-20260624
branch
from
June 26, 2026 10:48
247c465 to
ba80aff
Compare
lesj0610
force-pushed
the
lesj/flashinfer-workspace-sizing-helper-20260626
branch
from
June 26, 2026 10:48
bba4a75 to
9038328
Compare
lesj0610
changed the base branch from
lesj/nvfp4-slot-mapping-kv-cache-20260624
to
main
June 26, 2026 10:48
lesj0610
marked this pull request as ready for review
June 26, 2026 10:51
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lesj0610
marked this pull request as draft
June 26, 2026 10:52
lesj0610
marked this pull request as ready for review
June 26, 2026 11:41
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lesj0610
force-pushed
the
lesj/flashinfer-workspace-sizing-helper-20260626
branch
from
June 29, 2026 03:47
51281b2 to
f83d21a
Compare
Owner
Author
|
Upstream merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Add a caller-owned workspace sizing helper so integrations can allocate the FlashInfer float workspace to the actual planned requirement instead of always reserving the default workspace size.
This PR:
AlignedAllocatorso plan allocation offsets can be reused for sizing without touching workspace memory.workspace_sizeFFI functions that return required float and int workspace bytes.workspace_sizeon generated and JIT batch decode/prefill Python modules, withNonefor TRTLLM-gen where the helper is not available.workspace_size.plan_infolayout and runtime run paths unchanged.🔍 Related Issues
N/A
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Validation performed:
pre-commit run --all-filesFLASHINFER_DISABLE_VERSION_CHECK=1 MAX_JOBS=4 FLASHINFER_NVCC_THREADS=2 python -m pytest tests/attention/test_workspace_size.py -q -s -x --tb=shortNot yet verified:
Reviewer Notes
This PR is independent against
main.Summary by CodeRabbit
workspace_sizeto let callers size buffers before running.