Fix Privacy Builders field datatype to Vector of String#5
Closed
igorline wants to merge 1 commit intoleruaa:mainfrom
Closed
Fix Privacy Builders field datatype to Vector of String#5igorline wants to merge 1 commit intoleruaa:mainfrom
igorline wants to merge 1 commit intoleruaa:mainfrom
Conversation
according to mev-share specification builders are specified by their names which you can refer to on this page https://github.com/flashbots/dowg/blob/main/builder-registrations.json
Owner
|
Hmmm looks like you are right, according to the specs But the confusing part is that it's a Anyway, I was planning to migrate RPC types to alloy ones (see #2), so I'm sorry to say I don't think I will merge this. To conclude, I think it would be interesting to have this fixed in alloy. Do you mind open an issue? If you don't have time I will do it. |
Contributor
Author
|
Oh, I see. Will be opening PRs to alloy, thanks for pointing out |
Contributor
Author
|
Added PR to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to mev-share specification builders are specified by their names which you can refer to on this page
https://github.com/flashbots/dowg/blob/main/builder-registrations.json