Add back missing initializers to KeeAgentSettings

lerignoux · May 28, 2020 · f5fb0a0 · f5fb0a0
1 parent 3b06b3e
commit f5fb0a0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/src/sshagent/KeeAgentSettings.cpp b/src/sshagent/KeeAgentSettings.cpp
@@ -19,12 +19,6 @@
 #include "KeeAgentSettings.h"
 #include "core/Tools.h"
 
-KeeAgentSettings::KeeAgentSettings()
-    : m_lifetimeConstraintDuration(600)
-    , m_selectedType(QString("file"))
-{
-}
-
 bool KeeAgentSettings::operator==(const KeeAgentSettings& other) const
 {
     // clang-format off

diff --git a/src/sshagent/KeeAgentSettings.h b/src/sshagent/KeeAgentSettings.h
@@ -27,8 +27,6 @@
 class KeeAgentSettings
 {
 public:
-    KeeAgentSettings();
-
     bool operator==(const KeeAgentSettings& other) const;
     bool operator!=(const KeeAgentSettings& other) const;
     bool isDefault() const;
@@ -72,17 +70,17 @@ class KeeAgentSettings
     bool readBool(QXmlStreamReader& reader);
     int readInt(QXmlStreamReader& reader);
 
-    bool m_allowUseOfSshKey;
-    bool m_addAtDatabaseOpen;
-    bool m_removeAtDatabaseClose;
-    bool m_useConfirmConstraintWhenAdding;
-    bool m_useLifetimeConstraintWhenAdding;
-    int m_lifetimeConstraintDuration;
+    bool m_allowUseOfSshKey = false;
+    bool m_addAtDatabaseOpen = false;
+    bool m_removeAtDatabaseClose = false;
+    bool m_useConfirmConstraintWhenAdding = false;
+    bool m_useLifetimeConstraintWhenAdding = false;
+    int m_lifetimeConstraintDuration = 600;
 
     // location
-    QString m_selectedType;
+    QString m_selectedType = QString("file");
     QString m_attachmentName;
-    bool m_saveAttachmentToTempFile;
+    bool m_saveAttachmentToTempFile = false;
     QString m_fileName;
     QString m_error;
 };