Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Clippy - Simplified conditional logic in transition.rs. #615

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

martinfrances107
Copy link
Contributor

Just a couple of clippy fixes, only one is worth highlighting

all I have to say is when I draw out the equivalent logic elements this makes sense to me.

warning: this boolean expression can be simplified
   --> leptos/src/transition.rs:122:24
    |
122 |                       if (has_local_only && child_runs.get() > 0)
    |  ________________________^
123 | |                         || !has_local_only
    | |__________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
    = note: `#[warn(clippy::nonminimal_bool)]` on by default

@martinfrances107
Copy link
Contributor Author

This build failed

"No space left on device"

@gbj gbj merged commit 2dd9116 into leptos-rs:main Mar 3, 2023
@gbj
Copy link
Collaborator

gbj commented Mar 3, 2023

Thanks! We've added a couple more examples and tests so it's straining CI now occasionally, will fix independently of this.

@martinfrances107 martinfrances107 deleted the clippy_simplification branch March 3, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants