make counter test compile #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perry-birch
reviewed
Feb 27, 2023
| @@ -84,22 +84,22 @@ fn inc() { | |||
| let clear = div | |||
| .first_child() | |||
| .unwrap() | |||
| .dyn_into::<HtmlElement>() | |||
| .dyn_into::<web_sys::HtmlElement>() | |||
There was a problem hiding this comment.
I'm not certain these added turbofish are needed, the following command seems to run with just the other changes you proposed:
wasm-pack test --node
|
Thanks! I think you could probably consolidate some of the |
vaniusrb
pushed a commit
to vaniusrb/leptos
that referenced
this pull request
Mar 1, 2023
gbj
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a had to make some small tweaks to let the counter test example compile and pass.
I am not sure if web-sys is really needed, but it is used with websys::HtmlElement in the test.
please have a look at it.