Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Minor Updates on Examples #427

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Several Minor Updates on Examples #427

merged 2 commits into from
Feb 2, 2023

Conversation

Indrazar
Copy link
Contributor

@Indrazar Indrazar commented Feb 1, 2023

  • Added a button to errors_axum example to generate a 500 error with a <Form>
  • Correct README.md on errors_axum example
  • Ran clippy on errors_axum and todo_app_sqlite_axum examples
cargo clippy --no-deps --features="csr"
cargo clippy --no-deps --features="ssr"
cargo clippy --no-deps --features="hydrate"
  • Changed a few cfg_if blocks to help rust_analyzer code completion
  • Added "http://" to log so the page can be directly opened from the terminal when server starts

@gbj
Copy link
Collaborator

gbj commented Feb 1, 2023

The CI runs cargo fmt --check before running tests, and it failed — could you cargo fmt and push the changes?

@requaos
Copy link

requaos commented Feb 1, 2023

@gbj given the failure for note: /usr/bin/ld: final link failed: No space left on device will this ever pass? can we give the test runner more disk?

@gbj
Copy link
Collaborator

gbj commented Feb 2, 2023

@requaos This has happened occasionally in the past; I'm surprised it's started occurring again. I generally finish running the CI on my computer, which is not ideal but is fine. I had changed a GitHub setting immediately before this happened and have reverted it... It may have been related.

@gbj gbj merged commit 63a7a4d into leptos-rs:main Feb 2, 2023
gbj pushed a commit that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants