feat: #[component] now handles impl Trait by converting to generic type params, fix #2274
#2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
commented
May 21, 2024
MingweiSamuel
force-pushed
the
fix-2274
branch
2 times, most recently
from
4aa44bb
to
52fd080
Compare
MingweiSamuel
commented
May 21, 2024
MingweiSamuel
force-pushed
the
fix-2274
branch
3 times, most recently
from
d297e4f
to
1389b9f
Compare
…c type params, fix leptos-rs#2274 Book needs to be updated to remove this line: https://github.com/leptos-rs/book/blob/35c380ffc8f7d2e50ef21db97943138b3dba2728/src/view/03_components.md?plain=1#L233
|
Looks great -- Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2274 (for real)
Currently the
Idents generated are just in the form__ImplTrait0,__ImplTrait1, etc. Maybe could base it off of the argument names, to improve error messages if there are bugs.Book needs to be updated to remove this line:
https://github.com/leptos-rs/book/blob/35c380ffc8f7d2e50ef21db97943138b3dba2728/src/view/03_components.md?plain=1#L233