Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add caveats for ProtectedRoute #2558

Merged
merged 2 commits into from
May 1, 2024
Merged

docs: add caveats for ProtectedRoute #2558

merged 2 commits into from
May 1, 2024

Conversation

gbj
Copy link
Collaborator

@gbj gbj commented Apr 24, 2024

No description provided.

/// // parent route
/// <Route path="/" view=move || {
/// view! {
/// // only show the outlet when `is_loaded` is `true`, and hide it when it is `false`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you meant:

only show the outlet when is_loaded has_permission is true"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I changed the name to make more sense halfway through and missed this.

Copy link
Collaborator Author

@gbj gbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@gbj gbj merged commit da9711a into main May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants