Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'create_query_signal_with_options' to leptos_router #2517

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Add 'create_query_signal_with_options' to leptos_router #2517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1287e8
Add 'create_query_signal_with_options' version of 'create_query_signal'
kryesh Apr 11, 2024
324a6cf
Update nav_options clone
kryesh Apr 11, 2024
22dd5a7
Merge branch 'leptos-rs:main' into main
kryesh Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion router/src/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,17 @@ use std::{rc::Rc, str::FromStr};
pub fn create_query_signal<T>(
key: impl Into<Oco<'static, str>>,
) -> (Memo<Option<T>>, SignalSetter<Option<T>>)
where
T: FromStr + ToString + PartialEq,
{
create_query_signal_with_options::<T>(key, NavigateOptions::default())
}

#[track_caller]
pub fn create_query_signal_with_options<T>(
key: impl Into<Oco<'static, str>>,
nav_options: NavigateOptions,
) -> (Memo<Option<T>>, SignalSetter<Option<T>>)
where
T: FromStr + ToString + PartialEq,
{
Expand Down Expand Up @@ -77,7 +88,7 @@ where
let path = location.pathname.get_untracked();
let hash = location.hash.get_untracked();
let new_url = format!("{path}{qs}{hash}");
navigate(&new_url, NavigateOptions::default());
navigate(&new_url, nav_options.clone());
});

(get, set)
Expand Down
Loading