Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable semver checks #2471

Merged
merged 1 commit into from
Mar 30, 2024
Merged

ci: disable semver checks #2471

merged 1 commit into from
Mar 30, 2024

Conversation

agilarity
Copy link
Contributor

@agilarity agilarity commented Mar 30, 2024

This resolves #2470.

Changes

  • Allow the CI semver workflow to be triggered manually
    • This provides the option of trying again later
  • Do not trigger the CI semver on push

Notes

  • The blame for the errors seem to be external to the leptos code. Something changed around 03/24/2024 that now causes even previously passing commits to fail.

@agilarity
Copy link
Contributor Author

@benwis This is ready for review.

@obi1kenobi
Copy link

👋 Hey, I'm the cargo-semver-checks maintainer, and I'm looking into this as well. Of course feel free to merge this PR to get things unblocked while I look, I just want to get to the bottom of this one way or the other.

@agilarity
Copy link
Contributor Author

agilarity commented Mar 30, 2024 via email

@obi1kenobi
Copy link

Found the problem. It's not related to cargo-semver-checks but to an interaction between axum and the nightly Rust version used here.

To fix it, either downgrade axum or upgrade to a newer nightly Rust.

Here's what's going on:

I was stumped because I couldn't reproduce this problem on my own machine. But turns out I'm running 1.79-nightly which is new enough to have the feature in question.

@agilarity
Copy link
Contributor Author

I recommend merging this PR now and tackling a nightly upgrade later.

@agilarity agilarity marked this pull request as ready for review March 30, 2024 19:01
@benwis benwis merged commit e926ff2 into leptos-rs:main Mar 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: semver checks fail with a compiler error
3 participants