Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow #[prop(attrs)] on slots #2396

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: allow #[prop(attrs)] on slots #2396

merged 1 commit into from
Mar 5, 2024

Conversation

Upbolt
Copy link
Contributor

@Upbolt Upbolt commented Mar 2, 2024

Saw somebody in the Discord server ask for the ability to do

#[slot]
struct Slot {
  #[prop(attrs)]
  attributes: Vec<(&'static str, Attribute)>
}

Which currently is not implemented, so I just extended the existing options and slapped in the impls and methods in leptos_macro/slot.rs and leptos_macro/slot_helper.rs

@bram209
Copy link
Contributor

bram209 commented Mar 4, 2024

didn't look into the implementation of prop spreading at all, so could be unrelated, but had an issue with prop spreading just now (not on slots):
#2403

leaving it here for reference, just in case

@benwis
Copy link
Contributor

benwis commented Mar 5, 2024

Some real serendipity here, thanks for contributing!

@benwis benwis merged commit 372a241 into leptos-rs:main Mar 5, 2024
60 checks passed
@Upbolt Upbolt deleted the slot_attrs branch March 5, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants