Skip to content

make NavigationService throw-helpers protected (instead of private) #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomianowski merged 3 commits into from
Mar 13, 2024
Merged

make NavigationService throw-helpers protected (instead of private) #943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c080436
make `NavigationService` throw-helpers protected
Palatis Feb 9, 2024
9d7b7fc
Merge branch 'development' into feature/navsvc/private_to_protected
pomianowski Mar 13, 2024
11018e2
Update NavigationService.cs
pomianowski Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Wpf.Ui/NavigationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,15 @@ public bool NavigateWithHierarchy(Type pageType, object? dataContext)
return NavigationControl!.NavigateWithHierarchy(pageType, dataContext);
}

private void ThrowIfNavigationControlIsNull()
protected void ThrowIfNavigationControlIsNull()
{
if (NavigationControl is null)
{
throw new ArgumentNullException(nameof(NavigationControl));
}
}

private void ThrowIfPageServiceIsNull()
protected void ThrowIfPageServiceIsNull()
{
if (_pageService is null)
{
Expand Down