Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various brush fixes #839

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Various brush fixes #839

merged 5 commits into from
Nov 24, 2023

Conversation

niels9001
Copy link
Collaborator

This PR introduces the following changes:

  • Setting the default TitleBar fontsize to 12, which is inline with Fluent Design guidelines
  • A brush was set as a color, causing a crash whenever a ComboBoxItem was disabled: Disabled Item Error in ComboBox #794
  • A brush was set as a color, causing a crash whenever a NavigationView was in top mode: NavigationView crash #797
  • Adding dedicated Badge brushes to the resource dictionaries

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

This was referenced Nov 23, 2023
Closed
Open
@pomianowski pomianowski merged commit ada8fcb into lepoco:development Nov 24, 2023
2 checks passed
@pomianowski pomianowski mentioned this pull request Nov 24, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niels9001 @pomianowski