Fix ResizeMode of NoResize #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a conditional check to our WindowChrome initializer to only apply a ResizeBorderThickness when the ResizeMode is not set to “NoResize”
|
Would like to see this getting merged asap. This prevents my app from having custom non-resizable window with mica backdrop. |
pomianowski
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
ResizeModeofNoResizenot working when usingui:UiWindow.Pull request type
What is the current behavior?
Currently, setting the
ResizeModetoNoResizedoes not work without also setting theWindowStyletoNone. However, doing so breaks theming.Issue Number: #324, also possibly #109, #202, and #207
What is the new behavior?
A conditional check has been added to the
WindowChromeinitializer, which checks to see if theResizeModeis set toNoResize. If it is, theResizeBorderThicknesson the newWindowChromereceives a thickness of 0, which prevents resizing. Otherwise, default behavior is maintained.