Skip to content

Conversation

@keeleycenc
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

In LeftNavigationViewTemplate:

  • at the bottom of the menu item (PART_FooterMenuItemsItemsControl) nested within DynamicScrollViewer, with the main course of a single scroll
  • It does not meet users' interaction expectations for fixed bottom menus (such as Settings/exit buttons)
  • Visually, there is a lack of a separation line between the menu area and the bottom

What is the new behavior?

LeftNavigationViewTemplate changes:

  • The bottom menu is now fixed and not affected by the scrolling of the main menu
  • New dividing lines are added to clarify the visual hierarchy
  • Structural adjustment:
<!-- Before -->
DynamicScrollViewer
  ├─ MenuItems
  └─ FooterItems

<!-- After -->
DynamicScrollViewer
Separator
Fixed FooterItems

Other information

    • The Footer is always fixed at the bottom, and the interaction is more in line with the specifications of modern navigation controls such as Windows 11

bugfix-LeftNavigation

Scope of influence:

  • Only affects usingLeftNavigationViewTemplateNavigationView instance

@keeleycenc keeleycenc requested a review from pomianowski as a code owner May 19, 2025 05:35
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request navigation Changes to navigation related controls. release labels May 19, 2025
@pomianowski pomianowski merged commit 09f5641 into lepoco:main May 24, 2025
2 checks passed
@keeleycenc keeleycenc deleted the bugfix/LeftNavigation branch May 24, 2025 13:45
pomianowski added a commit that referenced this pull request May 26, 2025
pomianowski added a commit that referenced this pull request May 26, 2025
@huiyadanli
Copy link

image

The updated interface looks worse than before.

@keeleycenc
Copy link
Contributor Author

image

The updated interface looks worse than before.更新后的界面看起来比以前更糟糕。

This is a horizontal linear gradient with a smooth transition for the divider. Admittedly, design is subjective—some favor clearer sectioning, while others prefer absolute, distraction - free simplicity. Your perspective is really important.

We’ll re - evaluate possible adjustments during future optimizations, such as considering an option to toggle the divider on or off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controls Changes to the appearance or logic of custom controls. navigation Changes to navigation related controls. PR Pull request release styles Topic is related to styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants