Fix elevationBrushes to match WinUI #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the brush not-shared is necessary for it to work properly with content of any height
github-actions
bot
added
controls
pomianowski
approved these changes
Feb 1, 2025
pomianowski
pushed a commit
that referenced
this pull request
Feb 1, 2025
* Fix elevationBrushes to match WinUI Making the brush not-shared is necessary for it to work properly with content of any height * Fix elevation brush on ToggleButton as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Card controls that use
ControlElevationBrushshow broken borders, as the gradient remains at the height of regular button/combobox controls.Conversely, if Card controls are what are shown first, the ElevationBrush will not function properly for ComboBoxes and Buttons.
This also affects textboxes that are larger in height than the normal one. The replacement was to use a different ElevationBrush that does a full gradient, but this is non-canonical relative to WinUI.
I've also noticed that NumberBoxes/PasswordBoxes don't have a correct bottom border - The idea was probably to rely on the additional accent border instead, but that doesn't work as intended.
Issue Number: N/A
What is the new behavior?
Other information