Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: set match type correctly in riskywords detectors #918

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

leondz
Copy link
Owner

@leondz leondz commented Sep 18, 2024

Resolves #862

move riskyword string detectors over to configurable; fix the match type in riskywords; add tests for surge detectors

Verification

python -m pytest tests/detectors/test_detectors_riskywords.py

…ype in riskywords; add tests for surge detectors
@leondz leondz added bug Something isn't working detectors work on code that inherits from or manages Detector labels Sep 18, 2024
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jmartin-tech jmartin-tech merged commit 89143c8 into main Sep 19, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the bugfix/riskyword_match_scope branch September 19, 2024 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working detectors work on code that inherits from or manages Detector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The design of ”riskyword.py“might has shortcomings?
2 participants