Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate detector doc_uri #865

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

leondz
Copy link
Owner

@leondz leondz commented Aug 30, 2024

Many detectors are roll-our-own, so None is valid. If it's a string, it should be an absolute http address

@leondz leondz added the tests Testing-related label Aug 30, 2024
@jmartin-tech jmartin-tech merged commit 49b1e3f into main Aug 30, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the test/base_doc_uri_none_or_populated branch August 30, 2024 19:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests Testing-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants