Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin metadata tests #849

Merged
merged 12 commits into from
Aug 23, 2024
Merged

plugin metadata tests #849

merged 12 commits into from
Aug 23, 2024

Conversation

leondz
Copy link
Owner

@leondz leondz commented Aug 21, 2024

completes #161

@leondz leondz added the tests Testing-related label Aug 21, 2024
@leondz leondz linked an issue Aug 22, 2024 that may be closed by this pull request
12 tasks
@leondz leondz marked this pull request as ready for review August 22, 2024 06:46
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment typo.

Also offered an opinion on test structuring that could be deferred for future adjustment.

tests/detectors/test_detector_format.py Outdated Show resolved Hide resolved
garak/detectors/base.py Outdated Show resolved Hide resolved
@jmartin-tech jmartin-tech merged commit c2a42bf into main Aug 23, 2024
10 checks passed
@jmartin-tech jmartin-tech deleted the tests/plugin_metadata_tests branch August 23, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests Testing-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: plugin documentation is present
2 participants