stop encoding.payloads accumulating each load #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartin-tech
approved these changes
Jul 12, 2024
Comment on lines
+32
to
+42
| def test_encoding_payload_library_size_count(): | ||
| garak.probes.encoding._load_payloads() | ||
| payload_count = len(garak.probes.encoding.payloads) | ||
| p = garak.probes.encoding.InjectBase2048() | ||
| assert len(garak.probes.encoding.payloads) == payload_count | ||
| p = garak.probes.encoding.InjectZalgo() | ||
| assert len(garak.probes.encoding.payloads) == payload_count | ||
| p = garak.probes.encoding.InjectBase64() | ||
| assert len(garak.probes.encoding.payloads) == payload_count | ||
| garak.probes.encoding._load_payloads() | ||
| assert len(garak.probes.encoding.payloads) == payload_count |
There was a problem hiding this comment.
This test passes on main if calling the current load_payloads(), I suspect the test needs some more context on how to produce an accumulation of payloads during execution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #747
payload library length wasn't reset, leading to prompt accumulation