add 'complete' message to report at end of run #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leondz
added
the
reporting
garak/command.py
Outdated
| @@ -117,7 +123,7 @@ def end_run(): | |||
| print(f"📜 report html summary being written to {digest_filename}") | |||
| try: | |||
| write_report_digest(_config.transient.report_filename, digest_filename) | |||
| except Exception as e: | |||
| except BaseException as e: | |||
There was a problem hiding this comment.
Why BaseException?
Catching Exception is very broad already, this only adds GeneratorExit, KeyboardInterrupt and SystemExit as far as I can tell all of which I would expect to immediately terminate vs being able to recover in any meaningful way.
There was a problem hiding this comment.
reverted.
Would like to scope this down, actually - I am not sure what is being caught here, because Exception is an uninformative signal
jmartin-tech
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #726