Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #2; the API is now accessible at https://etf4u.herokuapp.com/
to query any given etf, simply do https://etf4u.herokuapp.com/query/{etf_ticker}, for example see the request for SPY
the API endpoint is a lite version of your main function. it only handles one ticker at a time; the idea is that the extra logic (e.g. include, exclude, clamp, combining...) can be applied after the API call
had to rewrite
requirements.txt
usingpipreq
(sorry don't know how poetry work)also using a timed version of the
lru_cache
that comes withfunctools
insteadand finally the API actually ignores the vanguard adapter because I ran into some issues getting seleium to work on Heroku (followed this guide to no avail). might deploy inside a docker container (i.e. like this one if it's a big deal). so to summarize, all the Vanguard ETFs are handled by the etfdb adapter.