Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployable to heroku using fastapi #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ohjho
Copy link
Contributor

@ohjho ohjho commented Mar 1, 2022

this closes #2; the API is now accessible at https://etf4u.herokuapp.com/

to query any given etf, simply do https://etf4u.herokuapp.com/query/{etf_ticker}, for example see the request for SPY

the API endpoint is a lite version of your main function. it only handles one ticker at a time; the idea is that the extra logic (e.g. include, exclude, clamp, combining...) can be applied after the API call

had to rewrite requirements.txt using pipreq (sorry don't know how poetry work)

also using a timed version of the lru_cache that comes with functools instead

and finally the API actually ignores the vanguard adapter because I ran into some issues getting seleium to work on Heroku (followed this guide to no avail). might deploy inside a docker container (i.e. like this one if it's a big deal). so to summarize, all the Vanguard ETFs are handled by the etfdb adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker image/ api
1 participant