guides: lead the index with the Agent Skills card - #258
Merged
Conversation
The catalogue is the newest work, so it takes the most prominent slot instead of the last one #241 gave it. That puts an inlined article above the getAllGuides() cards, which are sorted by updatedAt descending, so the placement is called out in a comment: it reads like a sorting bug otherwise and would get "fixed" back. A test pins the new order, since nothing else would catch a silent re-sort. The existing scoped "GitHub ↗" lookups still resolve, as both already narrow to their own <article>. Closes #255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
What
Moves the inlined Agent Skills
<article>inGuidesIndexRoute.tsxfrom the bottom of the guide list to the top, so it is the first card on/guides.PR #241 put it last on the reasoning that the one off-site entry belongs below the first-party pages. That's now overridden — it's the newest work and should be the most prominent.
The comment
The card now sits above
{guides.map(...)}, i.e. above content sorted byupdatedAtdescending. That reads like a sorting bug at a glance, so the block carries a comment saying the placement is deliberate and pointing at both issues. Without it someone eventually "fixes" it back.Tests
guides-route.test.tsxhad no ordering assertions, so a silent re-sort would not have been caught. Added one:leads the index with the agent skills card, ahead of the date-sorted guides— collects the sibling<article>cards and asserts the Agent Skills card is index 0 and the manager/worker markdown guide lands after it. Verified it is not vacuous: flipping the expectation to last-position makes it fail.No existing test needed changing. Both
GitHub ↗lookups were already scoped to their own<article>(the OpenCode Remote Control one since #241), so the duplicate match stays resolved after the reorder. ThegetAllByRole('link', { name: /read guide/ })[0]query is also unaffected — the Agent Skills CTA isbrowse skills ↗, notread guide.Verification
Node 26.3.0.
origin/main)npm run test:runweather-routes.test.tsxonlyweather-routes.test.tsxonlyIdentical failure set; the delta is the one new passing test. Those 35 are the known pre-existing Node 26 breakage — Node emits its own
localStoragethat shadows jsdom's, sowindow.localStorage.clear()in that file'sbeforeEachthrows. Reproduced on cleanorigin/mainfirst and left alone.npm run lint— cleannpm run build— succeedsBuild output is not committed, matching
main(docs/was last touched in #204, not per-change).Visual
Served the production build and read back the rendered card order on
/guides: