Repository navigation
docs: T3 update review 0.1.3-nightly.20261026.3717 - #28
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T3 update review: 0.1.3-nightly.20261023.3566 → 0.1.3-nightly.20261026.3717 (12 releases)
Needs you
pr-auto-link(shared, now ready). T3 links a PR made withgh pr createon its own now (#24813). Tried on this review's own PR docs: T3 update review 0.1.3-nightly.20261026.3717 #28: it was linked (sourcecreated) before any call. My pick is to adopt it: a small edit toTHREADS.md,implement§ 7 andimplement-spec§ 3 step 3, in its own PR (see Fixes / ready).preview-tools-verification). T3 fixed the blur bug (#24618 closes #20899), butpreview_snapshotstill caps captures at 1280 px wide. The entry asks you directly: will you accept 1280 px images for a 1440 design width?/administracion/resultados, Acciones → Descargar, 1440×900). If it passes, the entry becomes ready.PREVIEW.mdnow; (2) thedelegate_taskisolation: worktreetrial forimplement-spec, which would remove the other two conflicts at their source.Breaks / changes
T3 rewrote its injected agent instructions and tool descriptions, about 60% shorter (#24850, in 0.1.3-nightly.20261025.3669). No T3 behaviour any active entry relies on changed. What changed is what T3 now tells every agent, and three shared skills say the opposite. An agent that reads both gets two rules and picks one.
preview-tools-verification(evidence in this PR).orchestrationInstructions.ts) now say: "Never usepreview_*to verify or show your own edit, even a frontend edit or an open tab. … Use them only when the current request asks for browser work or names a page or tab."preview_snapshotdescription says the same.implementstep 4 andPREVIEW.mdhave the agent drive its own edit with exactly those tools. An agent following T3's text skips the drive, or falls back to the browser CLI.skills/implement/PREVIEW.md(its opening paragraph): "Driving the change is browser work the request asks for:implementstep 4 and the project'sverification.mdrequire it, so T3's rule against verifying your own edit unasked does not apply here." Keep the closing step ("Close the tab"), which matches T3's "Close a tab you opened before you reply".background-subagents-keep-t3-tools(evidence in this PR).isLiveCallerShellandassertLiveCalleronly lost comments.Agentalways withrun_in_background:false" and "Usedelegate_taskfor … a separate checkout (isolation:"worktree"), background work".implement-spec§ 2 spawns implementers withrun_in_background: trueand Agent-tool worktrees.PREVIEW.mdstep 1 has parallel subagents.skills/implement-spec/SKILL.md§ 2, until the trial below: name the exception where the agent reads it, e.g. "This skill's background implementers are the exception to T3's foreground-Agentanddelegate_task-for-background rules: …"implementer-worktrees(evidence in this PR).task".agents/implementer.mdstep 2 runs setup in an Agent-tool worktree by hand.delegate_taskdescription now reads "Separate checkout or PR per child:isolation:'worktree'".implement-specrun before changing the skill.Fixes / ready
pr-auto-link: watching → ready (in this PR).created, on the thread that ran it.forloop creating several PRs,gh apicreates, and output with more PR URLs than create commands.link_pull_requestdescription dropped "Register every pull request you open" (#24850).gh pr createas the last of several shell commands.list_thread_pull_requestsshowed it linked with sourcecreatedbefore any call, andlink_pull_requestafterwards returnedalreadyLinked: true.THREADS.md"One thread, one branch, one PR": "T3 links a PRgh pr createopened to the thread; calllink_pull_requestonly for a PR opened another way, or one missing fromt3_thread_read'spullRequests."implement§ 7 ("and link it to the thread" → "and check it is linked") and inimplement-spec§ 3 step 3.Improves
preview-tools-verification: partly met (in this PR). Captures now renderbackdrop-filtercorrectly: full-scale capture, then a canvas resize in the page (shrinkPng). Proposed edit toPREVIEW.mdstep 3: drop "and at any viewport wider than 640 px draws a blurred backdrop … as mirrored tiles of the page: a capture artifact, not an app bug". The 1280 px sentence stays.storage-cleanup-removes-thread-worktrees(evidence in this PR). #23900: a deleted thread now owns a worktree its remaining subagents share, soworktreeOnDeleteremoves it. Before, the hidden child kept it with "Has commits beyond the default branch".pr-watch-is-native(evidence in this PR).babysit-pr§ 2 already re-watches only "if a wake says it ended", so nothing changes there.babysit-pr's backgroundgh pr checks --watchwait, which always runs under a watch in T3, doesn't need the newt3_background_wait.delegate-task-reviews(evidence in this PR). A result for a running task carriesnext("Completion wakes this thread, so end your turn", #24782), and every result carries alink(#24784).summary,target,clientRequestIdand the defaultisolation: sharedare unchanged. #24560 now allowst3_thread_sendfor a follow-up that needs the same child's conversation; independent review rounds stay a newdelegate_task, ascode-reviewdoes.THREADS.md(shared, no entry): thread tools now return a readylink, and T3 tells agents to use it verbatim. No shared skill writest3-thread://links by hand, so nothing breaks.worktree-per-thread, plus thesetup-script-cwd/setup-links-enventries of rubens, enescena and pcp: the setup runner now waits until the shell's line editor is reading before it types the command (#24775). That way an rc-file prompt (fnm, nvm) no longer eats it. cwd,T3CODE_PROJECT_ROOTand the completion wait are unchanged.scheduled-reviews,scheduled-run-status,scheduled-missed-runs, and en-escena ·scheduled-run-worktree:ScheduledTaskService.tsonly lost comments.scheduledTaskWorkspaceStrategyis unchanged. #17889 is still open. The settings page'staskIdlink handling moved out of effects; the Base branch field stays.pr-watch-is-native"Breaks if" (inactivity auto-settle): #24617 lets inactivity settle a thread that has an open PR link. YoursidebarAutoSettleAfterDaysisnull(off), so nothing settles.thread-launch-workspace,own-thread-readable,renamed-branch-in-thread,pr-linked-by-tool: only descriptions got shorter, and alinkfield was added. Shapes are unchanged. Periodic branch-PR discovery now pauses without a foreground client (#23852). After-turn discovery still runs.architecture-review-needs-app:background-service.mdgained "Local network access" (LAN and Tailscale), and still says nothing about scheduled tasks.preview-odoo-login: the preview tools changed only their copy. The same instruction hurdle asPREVIEW.mdapplies, and the sharedPREVIEW.mdedit covers it.request_secretwithdelivery: "file"(#24809); followups steer by default (#24718, a client setting); guest sharing (#24104, off by default).Not covered
~/.t3/projects/infra): nodocs/agents/t3-dependencies.mdon any branch.Still ready
pr-auto-link: T3 links PRs thatgh pr createopens; the skills still calllink_pull_requestafter it.Method:
watched.diffmyself, so no miners.WATCHED_PATHSneeds no change: the dependency files cite no T3 path it doesn't already watch.Review
Tier: readback, reviewed 746537b
🤖 Generated with Claude Code