Repository navigation
feat(code-review): Long Function joins the smell baseline - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every project's Standards review now flags a long function: one whose happy path is buried under validation and detail. The fix is a helper named for a real concept, placed below the function; a helper with no concept of its own stays inline. No project has to add or rename anything, and a project's own standard still overrides the entry. The idea comes from opencode's
AGENTS.md(§ Complex Logic). No text is carried over, so there's nodecisions.mdrow and noNOTICEentry.Review
Tier: readback, reviewed 4fbb0b1
🤖 Generated with Claude Code