-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use workspaces to enable testing of bumped versions #646
base: master
Are you sure you want to change the base?
refactor: use workspaces to enable testing of bumped versions #646
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 91.09% 91.10% +0.01%
==========================================
Files 25 25
Lines 865 866 +1
Branches 234 234
==========================================
+ Hits 788 789 +1
Misses 70 70
Partials 7 7
☔ View full report in Codecov by Sentry. |
d58f15f
to
7232371
Compare
@leolabs This is now ready for review, all notes above. If you're happy with it, can you also update the required checks for the PRs as described? Thanks! |
c9eaa92
to
0956f0a
Compare
6793a75
to
3da0349
Compare
…hen changing the matrix job
3da0349
to
34195eb
Compare
Merged this in the fork with envelope-zero#1 |
This PR makes use of yarn workspaces to enable local testing even when versions are bumped.
It also:
results-${package}
job to every test workflow that checks the result of the matrix job. With that, the required checks can be updated to only require the following jobs:results-bank2ynab-converter
,results-parsers
,results-web-app
instead of updating the required checks every time a new node version is added to the matrix job.There's two things that need careful review:
/src
to the imports ofynap-parsers
andynap-bank2ynab-converter
. I have no idea if this is how it should be or if it will break when the packages are released .import
forBuffer
in the web app to fix aBuffer is undefined
error. I tested the web-app by runningyarn build
andyarn start
and then converting a file.@leolabs This change will enable #619 to run successful tests and be merged.